[UIK-4866] Small link/button-link underline style fix#2766
Conversation
|
|
||
| SText { | ||
| text-decoration: underline; | ||
| text-decoration-line: underline; |
There was a problem hiding this comment.
why do you use text-decoration-line here and without -line in Link?
There was a problem hiding this comment.
here text-decoration in the shorthand form caused text-decoration-thickness to not apply, in link there's no such problem, but we can do the same there for consistency. It's probably better to not mix shorthands and single attributes anyway
There was a problem hiding this comment.
actually no, I was wrong, the problem with thickness was only in the secondary use, and what fixed it was removing text-decoration: underline from SButton[use='secondary'] SText due to order of rules. So I will roll back this change
Did you check it with |
| <Link.Text w={w} ellipsis>{text} ellipsis</Link.Text> | ||
| </Link> | ||
| </Text> | ||
| <Text tag='div' mt={3} size={size}> |
There was a problem hiding this comment.
maybe it's better to remove this to render both links on the same line?
aa42615
into
UIK-4841/button-link-underline-v-17
Motivation and Context
bottom-padding— I think it's not needed now, but I'm not sure I remember correctly for which case it was addedtext-decoration-thicknessnot applying in secondary button linkHow has this been tested?
Manually.
Not uploading snapshots here because they haven't been updated in the parent branch, so they would contain some other changes apart from these.
Types of changes
Checklist: