Skip to content

[UIK-4939] panda preset#2800

Merged
ilyabrower merged 19 commits intorelease/v16from
UIK-4939/panda-preset
Mar 27, 2026
Merged

[UIK-4939] panda preset#2800
ilyabrower merged 19 commits intorelease/v16from
UIK-4939/panda-preset

Conversation

@slizhevskyv-semrush
Copy link
Copy Markdown
Contributor

@slizhevskyv-semrush slizhevskyv-semrush commented Mar 17, 2026

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@slizhevskyv-semrush slizhevskyv-semrush changed the title UI k 4939/panda preset [UIK-4939] panda preset Mar 17, 2026
@github-actions github-actions bot added the core label Mar 17, 2026
ilyabrower
ilyabrower previously approved these changes Mar 17, 2026
@Valeria-Zimnitskaya Valeria-Zimnitskaya removed the request for review from sheila-semrush March 18, 2026 13:22
@j-mnizhek
Copy link
Copy Markdown
Member

@slizhevskyv-semrush Vlad, we also have two sections in the documentation where you can browse and search tokens. For some reason, there are two JSON files for the base and token groups, and they’re not connected to the theme component 😭 So with the new changes, you’ll still only find palette tokens in the base section.

Can we change the source of the tokens on this page from the JSON files inside the docs to the JSON files in the current component?
image
image

j-mnizhek
j-mnizhek previously approved these changes Mar 26, 2026
Copy link
Copy Markdown
Member

@j-mnizhek j-mnizhek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good, I've updated the documentation and the order of fs and lh tokens.

Also left the comment about the documentation, but maybe this should be done in a separate task
#2800 (comment)

@ilyabrower
Copy link
Copy Markdown
Contributor

@slizhevskyv-semrush Vlad, we also have two sections in the documentation where you can browse and search tokens. For some reason, there are two JSON files for the base and token groups, and they’re not connected to the theme component 😭 So with the new changes, you’ll still only find palette tokens in the base section.

Can we change the source of the tokens on this page from the JSON files inside the docs to the JSON files in the current component? image image

I'll change this behavior in my branch with separate package for the theme

j-mnizhek
j-mnizhek previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Member

@j-mnizhek j-mnizhek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V celom, vsyo good! 👍

ilyabrower
ilyabrower previously approved these changes Mar 27, 2026
@ilyabrower ilyabrower dismissed stale reviews from Valeria-Zimnitskaya and themself via 459b4fa March 27, 2026 14:28
@ilyabrower ilyabrower enabled auto-merge (squash) March 27, 2026 14:29
@ilyabrower ilyabrower disabled auto-merge March 27, 2026 14:29
@ilyabrower ilyabrower merged commit 3f9b6b0 into release/v16 Mar 27, 2026
13 checks passed
@ilyabrower ilyabrower deleted the UIK-4939/panda-preset branch March 27, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants