Skip to content

[UIK-3427][stories] added always false selected for Options to prevent rendering selected line #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Valeria-Zimnitskaya merged 3 commits into from
Jun 1, 2026
+23 −12
Merged

[UIK-3427][stories] added always false selected for Options to prevent rendering selected line #2948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70471a1
[stories] added always false selected for Options to prevent renderin…
ilyabrower May 25, 2026
129d4dc
[chore] update test
Valeria-Zimnitskaya May 28, 2026
1d33b81
[stories] moved story to UX patterns folder in storybook
sheila-semrush Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions semcore/select/__tests__/ux-patterns-with-select/auto-suggest.browser-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ test.describe(TAG.FUNCTIONAL, () => {
await locators.options(page).first().waitFor({ state: 'visible' });

const count = await locators.options(page).count();
for (let i = 1; i < count; i++) {
for (let i = 0; i < count; i++) {
await expect(locators.options(page).nth(i)).toHaveAttribute('aria-selected', 'false');
await expect(locators.options(page).nth(i)).not.toHaveClass(/selected/);
}
});
Expand All @@ -121,7 +122,8 @@ test.describe(TAG.FUNCTIONAL, () => {
await page.keyboard.press('Enter');
await locators.options(page).first().waitFor({ state: 'visible' });
const count = await locators.options(page).count();
for (let i = 1; i < count; i++) {
for (let i = 0; i < count; i++) {
await expect(locators.options(page).nth(i)).toHaveAttribute('aria-selected', 'false');
await expect(locators.options(page).nth(i)).not.toHaveClass(/selected/);
}
});
Expand All @@ -136,23 +138,29 @@ test.describe(TAG.FUNCTIONAL, () => {
await expect(locators.trigger(page)).toHaveAttribute('value', 'ragdoll');
});

await test.step('Verify selected item shown and highlighted but not focused', async () => {
await test.step('Verify selected value is shown without selected option styling', async () => {
await page.keyboard.press('Enter');
await locators.options(page).first().waitFor({ state: 'visible' });
await expect(locators.options(page).first()).toHaveClass(/selected/);
await expect(locators.options(page).first()).toHaveText(/ragdoll/);
await expect(locators.options(page).first()).toHaveAttribute('aria-selected', 'false');
await expect(locators.options(page).first()).not.toHaveClass(/selected/);
await expect(locators.options(page).first()).not.toHaveClass(/highlighted/);
});

await test.step('Verify item is selected and menu not closed by Enter when exact match opened', async () => {
await test.step('Verify exact match keeps menu opened without selected option styling', async () => {
for (let i = 0; i < 'ragdoll'.length; i++) {
await page.keyboard.press('Backspace');
}
await page.keyboard.type('persian');
await locators.options(page).first().waitFor({ state: 'visible' });
await expect(locators.options(page).first()).toHaveText(/persian/);
await expect(locators.options(page).first()).toHaveClass(/selected/);
await expect(locators.options(page).first()).toHaveAttribute('aria-selected', 'false');
await expect(locators.options(page).first()).not.toHaveClass(/selected/);
await page.keyboard.press('Enter');
await expect(locators.menu(page)).toBeVisible();
await expect(locators.options(page).first()).toHaveText(/persian/);
await expect(locators.options(page).first()).toHaveClass(/selected/);
await expect(locators.options(page).first()).toHaveAttribute('aria-selected', 'false');
await expect(locators.options(page).first()).not.toHaveClass(/selected/);
});
});

Expand All @@ -176,7 +184,8 @@ test.describe(TAG.FUNCTIONAL, () => {

await expect(locators.menu(page)).toBeVisible();
const count = await locators.options(page).count();
for (let i = 1; i < count; i++) {
for (let i = 0; i < count; i++) {
await expect(locators.options(page).nth(i)).toHaveAttribute('aria-selected', 'false');
await expect(locators.options(page).nth(i)).not.toHaveClass(/selected/);
}
});
Expand All @@ -196,12 +205,14 @@ test.describe(TAG.FUNCTIONAL, () => {
await expect(locators.trigger(page)).toHaveAttribute('value', 'persian');
});

await test.step('Verify menu opened and selected option highlighted', async () => {
await test.step('Verify menu opened without selected option styling', async () => {
await page.mouse.click(inputCoords[0], inputCoords[1]);
await locators.options(page).first().waitFor({ state: 'visible' });
await expect(locators.trigger(page)).toHaveAttribute('value', 'persian');

await expect(locators.options(page).first()).toHaveClass(/selected/);
await expect(locators.options(page).first()).toHaveText(/persian/);
await expect(locators.options(page).first()).toHaveAttribute('aria-selected', 'false');
await expect(locators.options(page).first()).not.toHaveClass(/selected/);
await expect(locators.options(page).first()).not.toHaveClass(/highlighted/);
});
});
Expand Down
Binary file modified ...apshots/-visual-Verify-AutoSuggest-mouse-navigation-states-2-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...napshots/-visual-Verify-AutoSuggest-mouse-navigation-states-2-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...snapshots/-visual-Verify-AutoSuggest-mouse-navigation-states-2-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion stories/patterns/ux-patterns/auto-suggest/docs/AutoSuggest.docs.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import ComboboxExample from './examples/combobox_example';
import { playWrapper } from '../../../../utils/playWrapper';

const meta: Meta = {
title: 'Patterns/AutoSuggest',
title: 'Patterns/UX Patterns/AutoSuggest',
};
export default meta;

Expand Down
2 changes: 1 addition & 1 deletion stories/patterns/ux-patterns/auto-suggest/docs/examples/autosuggest_example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ const Demo = () => {
{suggestions.length > 0 && (
<Select.Menu>
{suggestions.map((option) => (
<Select.Option value={option.value} key={option.value}>
<Select.Option value={option.value} key={option.value} selected={false}>
<Highlight highlight={query}>{option.title}</Highlight>
</Select.Option>
))}
Expand Down
Loading