Lookup mapped catalogs for CatalogBrains #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Mar 22, 2023
Member
xispa
left a comment
xispa
left a comment
There was a problem hiding this comment.
You are overwriting the catalog variable passed through the request
xispa
approved these changes
Mar 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR adds an additional lookup for ZCatalog brains to fetch the right catalog for metadata lookup.
Current behavior before PR
If no
catalogrequest parameter is present, the JSON API always usesportal_catalogto fetch the brain metadata.Desired behavior after PR is merged
If no
catalogrequest parameter is present, the JSON API looks up the mapped catalogs for the portal type and returns the first found catalog from there for metadata lookup.--
I confirm I have tested the PR thoroughly and coded it according to PEP8
standards.