Skip to content

fix: skip decorative separators from block selection in preview#24

Merged
gavin-jeong merged 4 commits intomasterfrom
fix/skip-separator-selection-in-preview
Apr 18, 2026
Merged

fix: skip decorative separators from block selection in preview#24
gavin-jeong merged 4 commits intomasterfrom
fix/skip-separator-selection-in-preview

Conversation

@gavin-jeong
Copy link
Copy Markdown
Collaborator

Summary

  • Decorative separator lines (───) between messages in subagent/task preview were navigable and selectable via block cursor — this was meaningless
  • Added isDecorativeSeparator() helper and isBlockNavigable() to distinguish structural separators from content blocks
  • Separators still render normally but are skipped by keyboard nav, mouse clicks, and initial cursor placement

Test plan

  • Open a session with subagents, select a subagent in the left pane
  • Verify separator lines in the preview have no cursor indicator (›)
  • Arrow up/down through blocks — separators should be skipped
  • Click on a separator line — cursor should snap to nearest content block
  • Space-select blocks — separators should not be selectable

Separator lines (───) between messages in subagent/task previews were
navigable and selectable via block cursor, which was meaningless.
Now separators render without cursor prefix and are skipped by
keyboard navigation, mouse clicks, and initial cursor placement.
- Skip conversation entries with no text content (tool-only turns like
  auto-generated user messages) from agent/task preview
- Separators only added between entries that are actually emitted
@gavin-jeong gavin-jeong requested review from dikpaal and zzJinux April 17, 2026 12:19
Copy link
Copy Markdown

@jinsekim jinsekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Only skip entries with no text AND no tool_use blocks (pure tool_result
entries). Entries with tool_use blocks are kept since they represent
meaningful operations (e.g. background job commands).
Separate session agents from tasks/plan preview, fix worktree plan-memory capture, and align split-pane hints and boundary behavior with actual navigation.
@gavin-jeong gavin-jeong merged commit 9805530 into master Apr 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants