fix: Show X button on the Modal of mobile mode #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bang9
reviewed
Mar 13, 2024
src/ui/Modal/index.tsx
Outdated
| height="24px" | ||
| /> | ||
| </IconButton> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Q1. why isn't it included in header? 🤔
Q2. If there is no button available and customer were implementing custom buttons through renderHeader, what would happen? 🤔🤔
Contributor
Author
There was a problem hiding this comment.
A1. It seems the ModalHeader only contains the Label(text)
A2. hm... I see,, it will be good to move the CloseButton into the ModalHeader! Then the customers' customized header won't break, means the close Icons won't be duplicated
Let me apply that!
Contributor
Author
There was a problem hiding this comment.
The structure has become much more stable, Thank you @bang9 !!
HoonBaek
deleted the
fix/CLNP-2528/Add-X-button-to-the-all-members-mobile-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLNP-2528
ChangeLog & Fix