feat: Remove carousel component and use message template instead + some spec changes #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [v3.14.0-beta] (Mar 22, 2024) ### Fixes * Fixed a bug where swiping `Carousel` in mobile view displaying flickering effect * Added missing default `font-family` value to `sendbird-message-template__root`
bang9
reviewed
Mar 26, 2024
| ...renderData.carouselItem, | ||
| items: renderData.filledMessageTemplateItemsList, | ||
| }] as ComponentsUnion['properties'][] | ||
| } |
Contributor
There was a problem hiding this comment.
이거 이제 합쳐졌으니, RenderData 에 carouselItem 없어져도 되지 않나유?
Contributor
There was a problem hiding this comment.
filledMessageTemplateItemsList 요기 안에 캐러셀 아이템 포멧으루 들어갈 수 있을것 같슴다
AhyoungRyu
reviewed
Mar 27, 2024
Co-authored-by: Ahyoung Ryu <irene.ryu@sendbird.com>
chohongm
changed the title
chohongm
force-pushed
the
v3.14.0-beta
branch
2 times, most recently
from
f30634f to
d7adafb
Compare
AhyoungRyu
reviewed
Mar 27, 2024
| result.carouselItem = carouselItem; | ||
| result.templateVersion = cachedTemplate.version; | ||
| result.filledMessageTemplateItemsList = [{ | ||
| type: carouselItem.type as any, |
Contributor
There was a problem hiding this comment.
Suggested change
| type: carouselItem.type as any, | |
| type: carouselItem.type, |
What happen if we remove as any here?
Contributor
Author
|
This PR has been closed due to target branch is detached from HEAD. |
AhyoungRyu
deleted the
feat/v3/AC-1230-remove-carousel-component-and-use-message-template-instead
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: AC-1230
Changelogs
Carouselui component as message template returns carousel component instead