feat: Remove carousel component and use message template instead + some spec changes #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ahyoung Ryu <irene.ryu@sendbird.com>
chohongm
changed the title
AhyoungRyu
reviewed
Mar 28, 2024
| result.carouselItem = carouselItem; | ||
| result.templateVersion = cachedTemplate.version; | ||
| result.filledMessageTemplateItemsList = [{ | ||
| type: carouselItem.type as any, |
Contributor
There was a problem hiding this comment.
Do we have reason for converting its type to any here? I think it should be fine without this.
Contributor
Author
There was a problem hiding this comment.
No input is string but the type is a enum defined in the core package. The type is not exported so i could not import. I had to cast to any.
AhyoungRyu
approved these changes
Mar 28, 2024
Contributor
AhyoungRyu
left a comment
AhyoungRyu
left a comment
There was a problem hiding this comment.
LGTM. Please check the comment I left before you merge :)
chohongm
deleted the
feat/v3/AC-1230-remove-carousel-component-and-use-message-template-instead-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: AC-1230
Changelogs
Carouselui component as message template returns carousel component instead