fix: Fixed type error. #1037
Merged
fix: Fixed type error. #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnestarLee
requested review from
HoonBaek,
bang9,
chohongm and
chrisallo
and removed request for
HoonBaek and
bang9
chrisallo
reviewed
Apr 4, 2024
src/modules/ChannelSettings/components/ModerationPanel/BannedUserList.tsx
Outdated
Show resolved
Hide resolved
src/modules/EditUserProfile/components/EditUserProfileUI/EditUserProfileUIView.tsx
Show resolved
Hide resolved
chrisallo
reviewed
Apr 5, 2024
HoonBaek
reviewed
Apr 5, 2024
HoonBaek
approved these changes
Apr 5, 2024
Contributor
HoonBaek
left a comment
HoonBaek
left a comment
There was a problem hiding this comment.
LGTM! Thank you for this huge job!!
| setMembers(members); | ||
| setHasNext(memberUserListQuery.hasNext); | ||
| setChannelUpdateId(uuidv4()); | ||
| setChannelUpdateId?.(uuidv4()); |
Contributor
There was a problem hiding this comment.
This line should be removed (maybe conflict)
OnestarLee
deleted the
feat/v3/strict-typescript/CLNP-2687-strict-typescript3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed type errors when 'strictNullChecks' is 'true'.
슬랙으로 공유드린 내용 제외하고, 수정해도 특별히 문제 없을 만한 부분 우선 수정하였습니다.