fix: Fixed type error. #1043
Merged
fix: Fixed type error. #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnestarLee
requested review from
AhyoungRyu,
HoonBaek,
bang9,
chohongm and
chrisallo
and removed request for
HoonBaek and
bang9
Contributor
|
can you run |
chrisallo
approved these changes
Apr 8, 2024
|
|
||
| useLayoutEffect(() => { | ||
| const timeouts = []; | ||
| const timeouts: NodeJS.Timeout[] = []; |
Collaborator
There was a problem hiding this comment.
ReturnType<typeof setTimeout>[]로 수정하면 좋을것 같습니닷!
| const [requestString, setRequestString] = useState(''); | ||
| const [debouncingTimer, setDebouncingTimer] = useState(null); | ||
| const [requestString, setRequestString] = useState<string>(''); | ||
| const [debouncingTimer, setDebouncingTimer] = useState<NodeJS.Timeout | null>(null); |
Collaborator
There was a problem hiding this comment.
ReturnType<typeof setTimeout> | null
OnestarLee
force-pushed
the
feat/v3/strict-typescript/CLNP-2785-strict-typescript4
branch
from
699d5f1 to
7e4f6e4
Compare
Contributor
Author
|
run yarn lint:fix 돌려서 확인 하였습니다 |
OnestarLee
deleted the
feat/v3/strict-typescript/CLNP-2785-strict-typescript4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modules에서 고객사에게 영향이 없을것 같다고 예상되는 에러들 위주로 수정 하였습니다.