-
Notifications
You must be signed in to change notification settings - Fork 144
feat: Horizontal scroll support for suggested replies #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chohongm
merged 5 commits into
main
from
feat/AC-1727-add-horizontal-scroll-on-suggested-replies
May 2, 2024
Merged
feat: Horizontal scroll support for suggested replies #1061
chohongm
merged 5 commits into
main
from
feat/AC-1727-add-horizontal-scroll-on-suggested-replies
May 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8e4ddd6 to
8ad30fc
Compare
Contributor
|
could you rebase the branch? (resolve conflicts) |
d17d2b1 to
35424bd
Compare
bang9
reviewed
Apr 23, 2024
35424bd to
6a7e306
Compare
bang9
reviewed
Apr 26, 2024
0fff5fa to
c0513fb
Compare
bang9
reviewed
Apr 30, 2024
27577ea to
1102e8a
Compare
bang9
reviewed
May 2, 2024
bang9
approved these changes
May 2, 2024
Contributor
bang9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: AC-1727
Docs
https://sendbird.atlassian.net/wiki/spaces/SDK/pages/2336523995/Meeting+note+-+Horizontal+Suggested+Replies+-+240422
Figma
https://www.figma.com/file/SVbXU00FhjztekD8AiVukK/UIKit_Work-file_React?node-id=2440%3A6306&mode=dev
Changelogs
Features
suggestedRepliesDirectionglobal option which serves as vertical/horizontal scroll option forSuggestedReplies