Skip to content

fix: Set the message list padding with 12px in the mobile layout #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix: Set the message list padding with 12px in the mobile layout #1068

merged 2 commits into from
Apr 19, 2024

Conversation

@HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Apr 19, 2024 •
edited
Loading

Fix&ChangeLog

  • Set the message list padding with 12px in the mobile mode

@HoonBaek HoonBaek requested a review from chohongm April 19, 2024 05:50
@HoonBaek HoonBaek self-assigned this Apr 19, 2024
@netlify
Copy link

netlify bot commented Apr 19, 2024 •
edited
Loading

✅ Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 9dfebdf
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/6622125bdce04b00083a26da
😎 Deploy Preview https://deploy-preview-1068--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HoonBaek HoonBaek added v3.14.3 and removed v3.14.2 labels Apr 19, 2024
@HoonBaek HoonBaek requested a review from bang9 April 19, 2024 05:51
@bang9
Copy link
Contributor

bang9 commented Apr 19, 2024

Update title please~

bang9
bang9 reviewed Apr 19, 2024
View reviewed changes
src/modules/GroupChannel/components/MessageList/index.scss
Copy link
Contributor

@bang9 bang9 Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원래 모바일 패딩이 12px 였는데, 24로 나오는 버그인건가요?

Copy link
Contributor Author

@HoonBaek HoonBaek Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새로 발생한 이슈는 아니고요, 지금까지는 24px로 설정해 오고 있었는데 디자인을 보니 12px로 되어 있어서 수정했습니다.

Copy link
Contributor

@bang9 bang9 Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어엇.. 그럼 혹시 TextInput 여백은 24 그대로이던가요?

Copy link
Contributor

@bang9 bang9 Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

레이아웃이 자연스러워 보이지는 않아서요, 만약 변경할거면 여백이 들어가는 컴포넌트들 전체 확인이 필요할 것 같습니다.

Copy link
Contributor Author

@HoonBaek HoonBaek Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇.. 모바일에서 MessgeInput도 24가 아니라 16으로 되어있네요, 이것도 수정했습니다!

Copy link
Contributor

@bang9 bang9 Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업할때 조금이라도 이상한 부분들은 디테일 체크를 해서, 영향 줄수있는 부분들은 모두 체크하고 넘어가는게 좋습니다.

Copy link
Contributor Author

@HoonBaek HoonBaek Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message Edit Input 정도가 있을 것 같은데요, 이건 괜찮아 보입니다
image

Copy link
Contributor

@bang9 bang9 Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voice message input 도 좌우여백 24로 보이는데요, 요쪽은 어떤가요?

Copy link
Contributor Author

@HoonBaek HoonBaek Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voice message input의 경우에는 Desktop, mobile 모두 동일한 24px로 디자인이 되어 있습니다!

Copy link
Contributor

@bang9 bang9 Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scroll to bottom 버튼도 확인 한번만 부탁드려욤~

12인 경우

image

24인 경우

image

@HoonBaek HoonBaek changed the title use 12px padding in mobile mode release: v3.14.3 Apr 19, 2024
@HoonBaek HoonBaek requested a review from bang9 April 19, 2024 05:55
@HoonBaek HoonBaek changed the title release: v3.14.3 fix: Set the message list padding with 12px in the mobile mode Apr 19, 2024
@HoonBaek HoonBaek changed the title fix: Set the message list padding with 12px in the mobile mode fix: Set the message list padding with 12px in the mobile layout Apr 19, 2024
@HoonBaek HoonBaek merged commit 778aa35 into main Apr 19, 2024
@HoonBaek HoonBaek deleted the fix/message-list-padding-in-mobile branch April 19, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bang9 bang9 bang9 approved these changes

@chohongm chohongm Awaiting requested review from chohongm

Assignees

@HoonBaek HoonBaek

Labels

v3.14.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HoonBaek @bang9