Skip to content

fix: Add target subType to fileName in every case #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix: Add target subType to fileName in every case #1070

merged 2 commits into from
Apr 19, 2024

Conversation

@HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Apr 19, 2024 •
edited
Loading

Issue

  • it couldn't convert to the target fileType, if original file's name doesn't contain the file extension

@HoonBaek HoonBaek requested a review from bang9 April 19, 2024 08:56
@HoonBaek HoonBaek self-assigned this Apr 19, 2024
@netlify
Copy link

netlify bot commented Apr 19, 2024 •
edited
Loading

✅ Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 31c1721
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/662235edff4a490008182c3f
😎 Deploy Preview https://deploy-preview-1070--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HoonBaek HoonBaek requested a review from chohongm April 19, 2024 09:00
bang9
bang9 reviewed Apr 19, 2024
View reviewed changes
chohongm
chohongm approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@chohongm chohongm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bang9
bang9 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HoonBaek @bang9
Update src/utils/compressImages.ts
31c1721 
Co-authored-by: Hyungu Kang | Airen <gusrn1423@naver.com>
@HoonBaek HoonBaek merged commit c67c323 into main Apr 19, 2024
@HoonBaek HoonBaek deleted the fix/Add-target-subtype-to-origin-file branch April 19, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bang9 bang9 bang9 approved these changes

+1 more reviewer

@chohongm chohongm chohongm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@HoonBaek HoonBaek

Labels

v3.14.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HoonBaek @chohongm @bang9