Skip to content

fix: Add target subType to fileName in every case #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix: Add target subType to fileName in every case #1070

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e52cacc
Add target subType to fileName in everycase
HoonBaek Apr 19, 2024
31c1721
Update src/utils/compressImages.ts
HoonBaek Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/utils/compressImages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,9 @@ export const compressImage = ({
// Change the file.name & file.type for converting file type
const targetFileType = outputFormat === 'preserve' ? imageFile.type : `image/${outputFormat}`;
const targetSubtype = targetFileType.split('/').pop();
let targetName = '';
const dotIndex = imageFile.name.lastIndexOf('.');
if (dotIndex === -1) {
// No extension found, use the original filename
targetName = imageFile.name;
} else {
// Replace the old extension with the new one
targetName = imageFile.name.substring(0, dotIndex) + '.' + targetSubtype;
}
// targetName = `fileName.targetSubtype`
const targetName = `${dotIndex === -1 ? imageFile.name : imageFile.name.substring(0, dotIndex)}.${targetSubtype}`;
ctx.canvas.toBlob(
(blob) => {
if (blob) {
Expand Down