fix: scroll view when message height changed with suggested replies #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chohongm
reviewed
May 4, 2024
|
|
||
| const renderedCustomSeparator = useMemo(() => renderCustomSeparator?.({ message }) ?? null, [message, renderCustomSeparator]); | ||
|
|
||
| const prevShouldRenderSuggestedReplies = useRef(shouldRenderSuggestedReplies); |
Contributor
There was a problem hiding this comment.
Nice!! I could not think of this: useRef can recognize height changes of a component.
edit: oh its not a component but a state. Surprised this solution has no timing issue. But its nice that it works!!
bang9
force-pushed
the
fix/suggested-replies-medi-scroll
branch
from
772436e to
3799c6e
Compare
bang9
force-pushed
the
fix/suggested-replies-medi-scroll
branch
from
3799c6e to
5269698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: AC-2222