fix: Add rate limit to markAsDelivered call #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
force-pushed
the
fix/SBISSUE-7857/mark-as-delivered-limit
branch
from
a78460f to
3ef0db4
Compare
sravan-s
force-pushed
the
fix/SBISSUE-7857/mark-as-delivered-limit
branch
from
3ef0db4 to
d9c0ea7
Compare
HoonBaek
approved these changes
May 9, 2022
Contributor
HoonBaek
left a comment
HoonBaek
left a comment
There was a problem hiding this comment.
Oh this is the same fix with https://github.com/sendbird/sendbird-uikit-react/pull/144/files
but for v2. thanks
sdk.markAsDelivered is buggy. While SDK team is fixing it, use channel?.markAsDelivered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://sendbird.atlassian.net/browse/UIKIT-1718