Skip to content

Conversation

@HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Oct 14, 2022

For Internal Contributors

UIKIT-2385

Description Of Changes

  • Add disableMarkAsRead to the Channel comp
    • This prop disables calling markAsRead in the Channel component

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)

@HoonBaek HoonBaek requested a review from sravan-s October 14, 2022 02:31
@HoonBaek HoonBaek self-assigned this Oct 14, 2022
interface ChannelProviderInterface extends ChannelContextProps, MessageStoreInterface {
scrollToMessage?(createdAt: number, messageId: number): void;
messageActionTypes: Record<string ,string>;
messageActionTypes: Record<string, string>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

currentGroupChannel,
sdkInit,
hasMoreNext,
disableMarkAsRead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

Copy link
Contributor

@sravan-s sravan-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HoonBaek HoonBaek merged commit 755c846 into main Oct 14, 2022
@HoonBaek HoonBaek deleted the feat/UIKIT-2385/Add-option-to-disable-markAsRead branch October 14, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants