feat: replace renderToString(react-dom) with custom fn #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
force-pushed
the
fix/UIKIT-3403/react-dom-server
branch
from
1f936c9 to
893d6b8
Compare
HoonBaek
approved these changes
Mar 23, 2023
| @@ -1,23 +1,14 @@ | |||
| import React from 'react'; | |||
sravan-s
force-pushed
the
fix/UIKIT-3403/react-dom-server
branch
from
f9d7a64 to
2b711fe
Compare
sravan-s
force-pushed
the
fix/UIKIT-3403/react-dom-server
branch
from
2bf47bd to
ceb5797
Compare
sravan-s
added a commit
that referenced
this pull request
Jun 19, 2023
If a path is set on Rollup.config.externals, it wont be bundled to the library during rollup build step. We have removed react-dom/server in: #449 So, its okay to remove it
sravan-s
pushed a commit
that referenced
this pull request
Jun 20, 2023
If a path is set on Rollup.config.externals, it wont be bundled to the library during rollup build step. We have removed react-dom/server in: #449 So, its okay to remove it Fixes: https://sendbird.atlassian.net/browse/UIKIT-4191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace renderToString from react-dom/server with custom function
This function was creating issue in customers with cra@4 & react@17
fixes: https://sendbird.atlassian.net/browse/UIKIT-3403