chore: Remove react-dom/server from rollup.config #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a path is set on Rollup.config.externals, it wont be bundled to the library during rollup build step. We have removed react-dom/server in: #449 So, its okay to remove it
Contributor
Author
|
Build works: |
AhyoungRyu
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a path is set on Rollup.config.externals, it wont be bundled
to the library during rollup build step. We have removed react-dom/server
in: #449
So, its okay to remove it
Fixes: https://sendbird.atlassian.net/browse/UIKIT-4191