[Message]: Make the message component selectable #624
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
reviewed
Jun 9, 2023
Comment on lines
-3
to
-6
| .sendbird-label { | ||
| -webkit-user-select: none; | ||
| -webkit-touch-callout: none; | ||
| } |
Contributor
There was a problem hiding this comment.
Hey, thanks for this, but this is a workaround for certain mobile devices... anyways, will scope it down so that it works on only those devices ~
Contributor
There was a problem hiding this comment.
Also, sadly, we are not allowed to merge these PRs from ext. I will make a separate PR and add you as courtesy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know I'm not supposed to open PR as I'm not a contributer, but please take a look and let me know. I recently upgraded and found this. If I'm removing something that's essential, let me know I can try to help. I found this code is added from #550, so if the code I'm removing is supposed to work only on mobile, I'll try to add a media-query. Won't be offended if you close the PR also :)
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
Description Of Changes
Screen.Recording.2023-06-08.at.5.09.56.PM.mov