Skip to content

[Message]: Make the message component selectable #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Message]: Make the message component selectable #624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 17 additions & 22 deletions src/ui/Label/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
@import '../../styles/variables';

.sendbird-label {
-webkit-user-select: none;
-webkit-touch-callout: none;
}
Comment on lines -3 to -6
Copy link
Contributor

@sravan-s sravan-s Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this, but this is a workaround for certain mobile devices... anyways, will scope it down so that it works on only those devices ~

Copy link
Contributor

@sravan-s sravan-s Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, sadly, we are not allowed to merge these PRs from ext. I will make a separate PR and add you as courtesy

Copy link
Contributor

@sravan-s sravan-s Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#625


[class*=sendbird-label] {
font-family: var(--sendbird-font-family-default);
}
Expand Down Expand Up @@ -46,12 +41,12 @@
}

.sendbird-label--body-1 {
font-size: 14px;
font-weight: normal;
font-stretch: normal;
font-style: normal;
line-height: 1.43;
letter-spacing: normal;
font-size: 14px;
font-weight: normal;
font-stretch: normal;
font-style: normal;
line-height: 1.43;
letter-spacing: normal;
}

.sendbird-label--body-2 {
Expand Down Expand Up @@ -82,20 +77,20 @@
}

.sendbird-label--caption-1 {
font-size: 14px;
font-weight: 600;
font-stretch: normal;
font-style: normal;
line-height: 1.43;
letter-spacing: normal;
font-size: 14px;
font-weight: 600;
font-stretch: normal;
font-style: normal;
line-height: 1.43;
letter-spacing: normal;
}

.sendbird-label--caption-2 {
font-size: 12px;
font-weight: bold;
font-style: normal;
line-height: 1;
letter-spacing: normal;
font-size: 12px;
font-weight: bold;
font-style: normal;
line-height: 1;
letter-spacing: normal;
}

.sendbird-label--caption-3 {
Expand Down