Skip to content

fix: Improve sampling and bitrate of Voice Recording #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2023
Merged

fix: Improve sampling and bitrate of Voice Recording #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15cbc18
fix: change const of Voice Recording
HoonBaek Jun 23, 2023
28c8435
chore: remove the unused comment
HoonBaek Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/hooks/VoiceRecorder/WebAudioUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Thanks to https://codesandbox.io/s/media-recorder-api-downsampling-16k-mp3-encode-using-lame-js-forked-n1pblw
import { VOICE_RECORDER_AUDIO_SAMPLE_RATE } from '../../utils/consts';
import { WavHeader, Mp3Encoder } from '../../_externals/lamejs/lame.all';

function encodeMp3(arrayBuffer: ArrayBuffer): WavHeader {
Expand Down Expand Up @@ -39,7 +40,7 @@ function encodeMp3(arrayBuffer: ArrayBuffer): WavHeader {
function downsampleToWav(file: File, callback: (buffer: ArrayBuffer) => void): void {
// Browser compatibility
// https://caniuse.com/?search=AudioContext
const audioCtx = new AudioContext();
const audioCtx = new AudioContext({ sampleRate: VOICE_RECORDER_AUDIO_SAMPLE_RATE });
const fileReader = new FileReader();
fileReader.onload = function (ev) {
// Decode audio
Expand Down
4 changes: 2 additions & 2 deletions src/hooks/VoiceRecorder/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
BROWSER_SUPPORT_MIME_TYPE_LIST,
VOICE_MESSAGE_FILE_NAME,
VOICE_MESSAGE_MIME_TYPE,
VOICE_RECORDER_AUDIO_BITS,
VOICE_RECORDER_AUDIO_BIT_RATE,
} from '../../utils/consts';
import useSendbirdStateContext from '../useSendbirdStateContext';

Expand Down Expand Up @@ -91,7 +91,7 @@ export const VoiceRecorderProvider = (props: VoiceRecorderProps): React.ReactEle
setIsRecordable(true);
const mediaRecorder = new MediaRecorder(stream, {
mimeType: browserSupportMimeType,
audioBitsPerSecond: VOICE_RECORDER_AUDIO_BITS,
audioBitsPerSecond: VOICE_RECORDER_AUDIO_BIT_RATE,
});
mediaRecorder.ondataavailable = (e) => { // when recording stops
logger.info('VoiceRecorder: Succeeded getting an available data.', e.data);
Expand Down
3 changes: 2 additions & 1 deletion src/utils/consts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ export const SCROLL_BUFFER = 10;
export const VOICE_RECORDER_CLICK_BUFFER_TIME = 250;
export const VOICE_RECORDER_DEFAULT_MIN = 1000; // 1 seconds
export const VOICE_RECORDER_DEFAULT_MAX = 600000; // 10 minutes
export const VOICE_RECORDER_AUDIO_BITS = 128000;
export const VOICE_RECORDER_AUDIO_BIT_RATE = 12000;
export const VOICE_RECORDER_AUDIO_SAMPLE_RATE = 11025;
export const BROWSER_SUPPORT_MIME_TYPE_LIST = ['audio/webm', 'audio/mp4', 'audio/mpeg', 'audio/ogg'];

// voice message play
Expand Down