Skip to content

Conversation

@HoonBaek
Copy link
Contributor

For Internal Contributors

UIKIT-1461
UIKIT-1467

Description Of Changes

  • Block scrolling of body tag when pop-up components appear
  • Prevent unexpected scrolling when fetching messages
  • Add sample case for when chat app is smaller than page size

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)

@HoonBaek HoonBaek requested a review from sravan-s January 26, 2022 01:30
@HoonBaek HoonBaek self-assigned this Jan 26, 2022
Copy link
Contributor

@sravan-s sravan-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

@HoonBaek HoonBaek requested a review from sravan-s February 8, 2022 05:39

export const customer1 = () => fitPageSize(<CustomApp />);

export const customer2 = () => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it obvious(rename customer2 to something else) so that its easier to understand this is a page with scroll?

@HoonBaek HoonBaek merged commit 6ed6ace into main Feb 8, 2022
@HoonBaek HoonBaek deleted the fix/Fix-event-leakage-issues branch February 8, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants