Skip to content

CPLAT-10038: use real cell metrics for image previews#5

Merged
sf-jin-ku merged 7 commits into
sendbird:mainfrom
gavin-jeong:CPLAT-10038-slk-kitty-preview-cells
May 22, 2026
Merged

CPLAT-10038: use real cell metrics for image previews#5
sf-jin-ku merged 7 commits into
sendbird:mainfrom
gavin-jeong:CPLAT-10038-slk-kitty-preview-cells

Conversation

@gavin-jeong
Copy link
Copy Markdown
Collaborator

JIRA: https://sendbird.atlassian.net/browse/CPLAT-10038

Summary

  • use the terminal's detected cell pixel size for preview, kitty, and sixel image sizing
  • keep fullscreen image previews visually consistent with inline image sizing
  • avoid unexpectedly tiny fullscreen previews on terminals whose cell size differs from 8x16

Test plan

  • go test ./internal/image ./internal/ui ./cmd/slk

gavin-jeong and others added 4 commits May 22, 2026 19:32
Show available slash commands when typing / in compose, execute them through Slack's command endpoint, and merge the pending worktree input improvements for tmux keyboard reporting and clipboard paste handling.
Treat the observed alt+enter runtime event as a newline in compose and merge the langmap worktree's Korean keyboard shortcut normalization so modal shortcuts work under non-English layouts.
Use the terminal's detected cell pixel size for preview, kitty, and sixel image sizing so fullscreen previews no longer render unexpectedly tiny.
Resolve conflicts with main while preserving the PR feature changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@sf-jin-ku sf-jin-ku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed conflict resolution and/or existing changes for merge.

sf-jin-ku and others added 3 commits May 22, 2026 11:53
Bring the PR up to date with the merged input, activity, and file picker changes while preserving this PR's behavior.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Resolve the final overlap with Ctrl+Enter send handling while preserving this PR's feature behavior.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Resolve the final overlap after the slash command PR landed while preserving real cell metric image preview behavior.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@sf-jin-ku sf-jin-ku merged commit ddb3620 into sendbird:main May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants