Call constructor with an email inside unit test.#349
Closed
dlemstra wants to merge 1 commit intosendgrid:masterfrom
Closed
Call constructor with an email inside unit test.#349dlemstra wants to merge 1 commit intosendgrid:masterfrom
dlemstra wants to merge 1 commit intosendgrid:masterfrom
Conversation
Contributor
|
Hi @dlemstra, Unfortunately, we do need the CLA. If you don't mind, please sign it for us. Hopefully, there will be other contributions you will make :) |
|
Thanks @dlemstra for pointing that out. I missed the fact that in that second form of the constructor, the default value of |
Author
|
I found the issue because of the hacktoberfest and thought I could help out a bit. But I am not going to share my personal details for a simple change to your unit tests. Feel free to add my patch to your commits @stevensona. I am going to close this pull request. |
Contributor
|
Understood and thanks for graciously offering up your changes to @stevensona. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes sure that the other constructor of Email is called during the unit test. This should be merged before pull-request #345 that will fail on this test. The setter of Name should be changed to something like the code below by @stevensona inside his pull request:
p.s. I don't think we need a CLA for such a minor change in your unit tests or do we?