Skip to content

Added Code Review to Contributing.md#238

Merged
thinkingserious merged 1 commit intosendgrid:masterfrom
mptap:add-code-review-contrib
Oct 23, 2018
Merged

Added Code Review to Contributing.md#238
thinkingserious merged 1 commit intosendgrid:masterfrom
mptap:add-code-review-contrib

Conversation

@mptap
Copy link

@mptap mptap commented Oct 31, 2017 •
edited
Loading

Fixes #236

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added Code Review to Contributing.md

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@mptap mptap mentioned this pull request Oct 31, 2017
Closed
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dmowcomber
Copy link
Contributor

dmowcomber commented Feb 9, 2018

LGTM

clee
clee reviewed Feb 12, 2018
View reviewed changes
Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code and removed status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap labels Mar 6, 2018
@thinkingserious thinkingserious merged commit b2166a6 into sendgrid:master Oct 23, 2018
@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 23, 2018

Hello @mptap,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@clee clee clee left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Code Review to Contributing.md

6 participants

@mptap @SendGridDX @dmowcomber @thinkingserious @clee @mbernier