Skip to content

gofmt#258

Merged
thinkingserious merged 1 commit intosendgrid:masterfrom
whilei:gofmt-2018-Jun-16-22-58
Oct 23, 2018
Merged

gofmt#258
thinkingserious merged 1 commit intosendgrid:masterfrom
whilei:gofmt-2018-Jun-16-22-58

Conversation

@whilei
Copy link
Contributor

@whilei whilei commented Jun 16, 2018

Just ran

gofmt -w .

on the project root. That's all.

https://blog.golang.org/go-fmt-your-code


I made this PR with a project going on over at https://github.com/rotblauer/gofmt-att, and it's definitely a work in progress. So if I got something wrong, or this is annoying at all, please file an issue over there and we'll sort it out. On the other hand, if you think it's kind of funny like I do, please feel welcome to contribute or even fire up one of your own great automatic _gofmt_ers.

Run standard gofmt command on project root.

- go version go1.10.3 darwin/amd64
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 16, 2018
@SendGridDX
Copy link

SendGridDX commented Jun 16, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 16, 2018

Codecov Report

Merging #258 into master will decrease coverage by 63.71%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #258       +/-   ##
==========================================
- Coverage   71.07%   7.36%   -63.72%     
==========================================
  Files           3      33       +30     
  Lines         446    4307     +3861     
==========================================
  Hits          317     317               
- Misses        125    3986     +3861     
  Partials        4       4
Impacted Files Coverage Δ
sendgrid.go 84.9% <100%> (ø) ⬆️
examples/subusers/subusers.go 0% <0%> (ø)
examples/whitelabel/whitelabel.go 0% <0%> (ø)
examples/stats/stats.go 0% <0%> (ø)
examples/user/user.go 0% <0%> (ø)
examples/contactdb/contactdb.go 0% <0%> (ø)
examples/browsers/browsers.go 0% <0%> (ø)
examples/devices/devices.go 0% <0%> (ø)
examples/mailsettings/mailsettings.go 0% <0%> (ø)
docker/get-version.go 0% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588320a...e635613. Read the comment docs.

@thinkingserious
Copy link
Contributor

Thanks @whilei! This is on our backlog for a merge.

@jpurpura jpurpura added difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy labels Aug 13, 2018
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap and removed status: code review request requesting a community code review or review from Twilio labels Oct 3, 2018
@thinkingserious thinkingserious merged commit 15a27a7 into sendgrid:master Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @whilei,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants