Skip to content

fix: Accept empty html on Email helper NewSingleEmail()#272

Merged
thinkingserious merged 5 commits intosendgrid:mainfrom
tjun:feature/accept-empty-html
Oct 1, 2020
Merged

fix: Accept empty html on Email helper NewSingleEmail()#272
thinkingserious merged 5 commits intosendgrid:mainfrom
tjun:feature/accept-empty-html

Conversation

@tjun
Copy link
Contributor

@tjun tjun commented Sep 30, 2018

Fixes #266

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Accept Empty HTML content on Email helper NewSingleEmail function

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 30, 2018
@SendGridDX
Copy link

SendGridDX commented Sep 30, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 30, 2018

Codecov Report

❗ No coverage uploaded for pull request base (main@41702ac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage        ?   71.14%           
=======================================
  Files           ?        3           
  Lines           ?      454           
  Branches        ?        0           
=======================================
  Hits            ?      323           
  Misses          ?      127           
  Partials        ?        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41702ac...41c7054. Read the comment docs.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty labels Oct 2, 2018
@childish-sambino childish-sambino removed the type: community enhancement feature request not on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:33
@thinkingserious thinkingserious changed the title Accept empty html on Email helper NewSingleEmail() fix: Accept empty html on Email helper NewSingleEmail() Oct 1, 2020
@thinkingserious thinkingserious merged commit db3fb54 into sendgrid:main Oct 1, 2020
@tjun tjun deleted the feature/accept-empty-html branch May 9, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email helper NewSingleEmail() requires both plainText and html content

5 participants