Skip to content

feat: add function for signature verification#390

Merged
brpat07 merged 6 commits intomasterfrom
eistats-1123-2
May 7, 2020
Merged

feat: add function for signature verification#390
brpat07 merged 6 commits intomasterfrom
eistats-1123-2

Conversation

@brpat07
Copy link
Contributor

@brpat07 brpat07 commented May 6, 2020

Fixes

Use the VerifySignature function to verify signed event webhook requests.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #390 into master will increase coverage by 0.29%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
+ Coverage   72.57%   72.87%   +0.29%     
==========================================
  Files           4        4              
  Lines         485      505      +20     
==========================================
+ Hits          352      368      +16     
- Misses        128      130       +2     
- Partials        5        7       +2     
Impacted Files Coverage Δ
helpers/eventwebhook/eventwebhook.go 79.31% <79.31%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c30ae7...296af5a. Read the comment docs.

Copy link

@anujs3 anujs3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (please get a review from the wonderful DX team too)

Copy link
Contributor

@thavanle thavanle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from naming refactor.

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brpat07 brpat07 merged commit 640cd9b into master May 7, 2020
@brpat07 brpat07 deleted the eistats-1123-2 branch May 7, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants