feat: add function for signature verification#390
Merged
Conversation
anujs3
reviewed
May 6, 2020
anujs3
reviewed
May 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 72.57% 72.87% +0.29%
==========================================
Files 4 4
Lines 485 505 +20
==========================================
+ Hits 352 368 +16
- Misses 128 130 +2
- Partials 5 7 +2
Continue to review full report at Codecov.
|
anujs3
approved these changes
May 6, 2020
anujs3
left a comment
There was a problem hiding this comment.
LGTM (please get a review from the wonderful DX team too)
thavanle
reviewed
May 6, 2020
thavanle
reviewed
May 6, 2020
anujs3
reviewed
May 6, 2020
anujs3
reviewed
May 7, 2020
Contributor
childish-sambino
left a comment
There was a problem hiding this comment.
LGTM aside from naming refactor.
anujs3
reviewed
May 7, 2020
anujs3
approved these changes
May 7, 2020
anujs3
reviewed
May 7, 2020
anujs3
reviewed
May 7, 2020
anujs3
reviewed
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Use the
VerifySignaturefunction to verify signed event webhook requests.Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.