feat: support context.Context#433
Merged
JenniferMah merged 1 commit intosendgrid:mainfrom May 3, 2021
Merged
Conversation
thinkingserious
added
the
status: code review request
johejo
force-pushed
the
support_context
branch
2 times, most recently
from
0e124c9 to
0af3ca9
Compare
JenniferMah
reviewed
Apr 29, 2021
Contributor
JenniferMah
left a comment
JenniferMah
left a comment
There was a problem hiding this comment.
Hi @johejo thanks for your PR! Can you add some tests that include a basic request with and without context?
Add SendWithContext, MakeRequestWithContext, MakeRequestRetryWithContext and MakeRequestAsyncWithContext. Closes sendgrid#403
Contributor
Author
|
@JenniferMah |
JenniferMah
approved these changes
May 3, 2021
Contributor
JenniferMah
left a comment
JenniferMah
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SendWithContext, MakeRequestWithContext, MakeRequestRetryWithContext and MakeRequestAsyncWithContext.
closes #403
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.