Cannot send email with specific content

[vanta]

Issue Summary

Emails containing specific content cannot be send using SG, due to content validation.

I cannot find any documentation of this "feature".

Please narrow validation and document it or remove it at all.

Steps to Reproduce

1. Try to send email with following content: SG..

Result:
IllegalArgumentException: Found a Forbidden Pattern in the content of the email

Technical details:

This error it because of content validation using regexp .*SG\.[a-zA-Z0-9(-|_)]*\.[a-zA-Z0-9(-|_)]*.*, which is so wide. AFAIU this is to prevent leakage of SG API KEYs, but it block legal content to be sent.

[thinkingserious]

Thanks for bringing this to our attention @vanta, I've added this to our backlog for a fix and labeled it for outside contribution.

With Best Regards,

Elmer

[jalp]

Hi, we are having the same problem. We are using several templates containing SG. text and this verify method is rejecting all the mails using these templates.

Do you have any estimation time to solve it?

Many thanks in advance!

[vanta]

@thinkingserious Do you need a PR for it?

[thinkingserious]

Thanks @vanta!!

My suggestion would be to make that call optional as well.

A PR would help move this issue up the backlog as well as +1 and/or comments.

With best regards,

Elmer

[childish-sambino]

I'm just gonna rip this code out. We don't do this in any of the other libraries and it only guards against a specific secret. PR coming soon.