Sendgrid resources cannot be cleaned up elegantly

[steaks]

This library claims resources primarily through

this.pool = Executors.newFixedThreadPool(THREAD_POOL_SIZE) //ExecutorService
this.client = new Client() //CloseableHttpClient

The library provides no mechanism for releasing these resources. Consumers of the api should be able to release the resources elegantly when they're finished using Sendgrid.

For reference, see the ExecutorService's documentation for shutting down https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ExecutorService.html and the Closeable interface's documentation for closing https://docs.oracle.com/javase/8/docs/api/java/io/Closeable.html

[thinkingserious]

Hello @steaks,

It looks like we had the same issue in our twilio-java SDK, solved by this PR.

Pull requests to add this feature are welcome and will be reviewed based on priority, but Twilio SendGrid is not actively building new functionality for the library.

With best regards,

Elmer

[steaks]

@thinkingserious thanks for responding. That's really helpful to know!

Has SendGrid changed their recommendation about how systems should be interacting with their API? Should I be interacting directly with the REST API rather than using this library?

[childish-sambino]

This library is still the recommended way of interacting with the API, and PRs to address bugs and features will still be reviewed. Building out new features is just a lower priority right now.

[thinkingserious]

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you!