Skip to content

Added unittest to check for specific repo files #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbernier merged 2 commits into from
Oct 31, 2017
Merged

Added unittest to check for specific repo files #362

mbernier merged 2 commits into from
Oct 31, 2017

Conversation

@mptap
Copy link

@mptap mptap commented Oct 28, 2017 •
edited
Loading

Closes: #355

Description of the change:
Added unittest to check for specific repo files mentioned in #355

If you have questions, please send an email Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@mptap mptap mentioned this pull request Oct 28, 2017
Closed
@mptap mptap force-pushed the add-test-files-exist branch from 62aaabe to c81edde Compare October 28, 2017 20:36
@mbernier
Copy link
Contributor

mbernier commented Oct 28, 2017

We are just waiting on #363 to be done in order to merge this in!

@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 28, 2017
mithunsasidharan
mithunsasidharan reviewed Oct 29, 2017
View reviewed changes
src/test/java/com/sendgrid/TestRequiredFilesExist.java Outdated
// ./Docker or docker/Docker
@Test public void checkDockerExists() {
boolean dockerExists = new File("./Docker").exists() ||
new File("./docker/Docker").exists();
Copy link
Contributor

@mithunsasidharan mithunsasidharan Oct 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it docker/Dockerfile ?

@mbernier
Copy link
Contributor

mbernier commented Oct 31, 2017 •
edited
Loading

Your build failure is due to this code working (odd, yeah?)! Thank you so much!

Thanks!

@mbernier mbernier merged commit f4426b1 into sendgrid:master Oct 31, 2017
@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 31, 2017

Hello @mptap,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier
Copy link
Contributor

mbernier commented Oct 31, 2017

TestRequiredFilesExist > checkLicenseExists FAILED
java.lang.AssertionError at TestRequiredFilesExist.java:65
TestRequiredFilesExist > checkCodeClimateExists FAILED
java.lang.AssertionError at TestRequiredFilesExist.java:40
TestRequiredFilesExist > checkDockerComposeExists FAILED
java.lang.AssertionError at TestRequiredFilesExist.java:20
TestRequiredFilesExist > checkEnvSampleExists FAILED
java.lang.AssertionError at TestRequiredFilesExist.java:25

Ahhhh, yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mithunsasidharan mithunsasidharan mithunsasidharan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add unittest to check for specific repo files

4 participants

@mptap @mbernier @thinkingserious @mithunsasidharan