Personalization.getSubstitutions() return type incorrect in index.d.ts TypeScript definition file #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…airs, not an array of objects. Refer to this.addSubstitutions() and this.getSubstitutions() methods in the mail.js helper source code at: https://github.com/sendgrid/sendgrid-nodejs/blob/master/lib/helpers/mail /mail.js
thinkingserious
added
status: code review request
Contributor
|
Hello @blove, |
Contributor
Author
|
It appears that the Travis build failed, but the error do not appear to be related to my simple update to the index.d.ts TypeScript definition file. Multiple tests failed with:
|
Contributor
thinkingserious
added a commit
that referenced
this pull request
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #367.