Skip to content

Conversation

@hpaul
Copy link
Contributor

@hpaul hpaul commented May 30, 2017

There is a problem when you send a sendgrid request with model created by helper.Mail personalizations does not converter to JSON.

I fixed this.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 30, 2017
@SendGridDX
Copy link

SendGridDX commented May 30, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thanks @hpaul!

Could you please take a moment to sign our CLA? It just takes a minute or two. There are a few form fields to fill out and a submit button. Thanks!

With Best Regards,

Elmer

@thinkingserious thinkingserious merged commit c68e7d7 into sendgrid:master Jun 1, 2017
@thinkingserious
Copy link
Contributor

Hello @hpaul,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Jun 1, 2017
@hpaul
Copy link
Contributor Author

hpaul commented Jun 2, 2017

Thanks for the swag 😎

@thinkingserious
Copy link
Contributor

No problem @hpaul.

There was a hiccup; however. Our swag automation failed because the zip code field was not filled out. Could you please fill out the form again? My apologies, we delete your personal data after we send the API call to our swag vendor.

Thanks!

@hpaul
Copy link
Contributor Author

hpaul commented Jun 2, 2017

I filled again.

@thinkingserious
Copy link
Contributor

That worked, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants