Integration of nodemailer-sendgrid-transport#707
Merged
thinkingserious merged 0 commit intosendgrid:masterfrom Dec 21, 2018
Merged
Integration of nodemailer-sendgrid-transport#707thinkingserious merged 0 commit intosendgrid:masterfrom
thinkingserious merged 0 commit intosendgrid:masterfrom
Conversation
Contributor
|
This is awesome, thanks! I've added this to our backlog for review. |
Contributor
|
Hello @Berkmann18, |
Contributor
Author
|
@thinkingserious You're welcome. |
|
Was this PR rolled back? Can't find a not vulnerable version of nodemailer-sendgrid-transport that works with SendGrid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Closes nodemailer-sendgrid-transport#67.
Checklist
Short description of what this PR does:
nodemailer-sendgrid-transportpackage as a sub-package among others (while having it match and follow the structure/convention used by other sub-packages).If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.
Note: (as discussed in the PR mentioned above): the
npm testfails due to the usage of the formersendgridpackage in this codebase with some API changes and some sub-packages not available yet on NPM (causing allrequire('@sendgrid/xxx')to fail).