Skip to content

chore: add style standards check #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thinkingserious merged 1 commit into from
Oct 22, 2018
Merged

chore: add style standards check #69

thinkingserious merged 1 commit into from
Oct 22, 2018

Conversation

@pangaunn
Copy link
Contributor

@pangaunn pangaunn commented Oct 6, 2018 •
edited
Loading

Fixes

Fixes #66

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Add go fmt script in .travis.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 6, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 6, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@devchas devchas added difficulty: medium fix is medium in difficulty hacktoberfest status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap labels Oct 17, 2018
@thinkingserious thinkingserious added status: ready for deploy code ready to be released in next deploy status: hacktoberfest approved and removed status: code review request requesting a community code review or review from Twilio status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018
@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 22, 2018

Hello @pangaunn,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit c3e051d into sendgrid:master Oct 22, 2018
@thinkingserious thinkingserious changed the title Add style standards check chore: add style standards check Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Require conformance to style standards

4 participants

@pangaunn @SendGridDX @thinkingserious @devchas