Update test parameterization for task_type#110
Update test parameterization for task_type#110tekrajchhetri merged 1 commit intofix_json_op_issuefrom
Conversation
Removed 'keyphrase_extraction' from task_type parameterization in tests.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies src/tests/task_detection_test.py by removing keyphrase_extraction from the task_type parameterization in test_task_type_from_config. The review feedback indicates that this change reduces test coverage for a supported task type, potentially leading to undetected regressions, and suggests re-including it to ensure proper functionality.
|
|
||
|
|
||
| @pytest.mark.parametrize("task_type", ["ner", "extraction", "keyphrase_extraction"]) | ||
| @pytest.mark.parametrize("task_type", ["ner", "extraction"]) |
There was a problem hiding this comment.
The keyphrase_extraction task type is still defined in src/utils/task_detection.py (e.g., in DEFAULT_TAXONOMY and TOOLS_BY_TASK_TYPE). Removing it from this test's parameterization reduces test coverage for a supported task type, which could lead to undetected regressions if its handling changes. It should be included to ensure proper functionality.
| @pytest.mark.parametrize("task_type", ["ner", "extraction"]) | |
| @pytest.mark.parametrize("task_type", ["ner", "extraction", "keyphrase_extraction"]) |
1 participant
Removed 'keyphrase_extraction' from task_type parameterization in tests based on the updated code.