Skip to content

Fix StructSenseFlow.__init__ parameter name: input_source -> source#97

Merged
tekrajchhetri merged 1 commit intofix_json_op_issuefrom
test_fix_json_op_issue_20260312
Mar 19, 2026
Merged

Fix StructSenseFlow.__init__ parameter name: input_source -> source#97
tekrajchhetri merged 1 commit intofix_json_op_issuefrom
test_fix_json_op_issue_20260312

Conversation

@puja-trivedi
Copy link
Copy Markdown
Contributor

The parameter was renamed to input_source in the signature but the method body still referenced source, causing a TypeError when called from the CLI.

  File "/Users/pujatrivedi/Desktop/MIT/structsense/src/structsense/cli.py", line 102, in extract
    flow = StructSenseFlow(
           ^^^^^^^^^^^^^^^^
TypeError: StructSenseFlow.__init__() got an unexpected keyword argument 'source'

The parameter was renamed to input_source in the signature but the
method body still referenced source, causing a TypeError when
called from the CLI.
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical TypeError that prevented the StructSenseFlow class from being correctly instantiated when called from the command-line interface. The fix involves a straightforward but essential correction to a parameter name in the constructor's signature, ensuring consistency with how the parameter is utilized internally. This resolves a functional bug and improves the robustness of the application's initialization process.

Highlights

  • Parameter Name Correction: The input_source parameter in the StructSenseFlow.__init__ method signature has been renamed to source to align with its usage within the method body.
  • Bug Fix: This change resolves a TypeError that occurred when calling StructSenseFlow from the CLI, which was caused by a mismatch between the parameter name in the signature and the name referenced internally.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly addresses the TypeError by renaming the input_source parameter to source in the StructSenseFlow.__init__ method. The change aligns with the problem description and ensures consistency between the method signature and its usage within the method body and docstring.

@puja-trivedi puja-trivedi mentioned this pull request Mar 18, 2026
@tekrajchhetri tekrajchhetri merged commit 7183fcc into fix_json_op_issue Mar 19, 2026
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants