Skip to content

refactor: use camino's UTF-8 paths everywhere#151

Merged
andrius-puksta-sensmetry merged 6 commits intomainfrom
ap/camino
Jan 27, 2026
Merged

refactor: use camino's UTF-8 paths everywhere#151
andrius-puksta-sensmetry merged 6 commits intomainfrom
ap/camino

Conversation

@andrius-puksta-sensmetry
Copy link
Copy Markdown
Collaborator

@andrius-puksta-sensmetry andrius-puksta-sensmetry commented Dec 31, 2025

Also use camino-tempfile instead of tempfile to get UTF-8 paths for tempfiles.

Closes #136.

Copy link
Copy Markdown
Collaborator

@victor-linroth-sensmetry victor-linroth-sensmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should wrapfs also be converted to camino paths/pathbufs? If there is nothing hindering us from doing this it seems like it could make things a bit more concise and uniform.

Comment thread core/src/env/local_directory.rs Outdated
Comment thread core/src/resolve/file.rs Outdated
Comment thread core/src/discover.rs Outdated
@andrius-puksta-sensmetry
Copy link
Copy Markdown
Collaborator Author

Question: Should wrapfs also be converted to camino paths/pathbufs? If there is nothing hindering us from doing this it seems like it could make things a bit more concise and uniform.

I left some of them using std Path because we use std paths returned from dirs crate to call wrapfs. On second thought, though, since this is the only use of std paths remaining, I'll just call the std API directly to avoid a verbose conversion.

@victor-linroth-sensmetry
Copy link
Copy Markdown
Collaborator

victor-linroth-sensmetry commented Jan 14, 2026

I left some of them using std Path because we use std paths returned from dirs crate to call wrapfs. On second thought, though, since this is the only use of std paths remaining, I'll just call the std API directly to avoid a verbose conversion.

Long term I'm considering removing the dirs dependency anyway, since we probably want more fine grained control over where to load config files, but there's no urgency at the moment.

Comment thread core/src/resolve/file.rs Outdated
@andrius-puksta-sensmetry andrius-puksta-sensmetry force-pushed the ap/camino branch 2 times, most recently from 135160c to b63b4c1 Compare January 22, 2026 13:17
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Copy link
Copy Markdown
Member

@tilowiklundSensmetry tilowiklundSensmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@andrius-puksta-sensmetry andrius-puksta-sensmetry merged commit 116269e into main Jan 27, 2026
55 checks passed
@andrius-puksta-sensmetry andrius-puksta-sensmetry deleted the ap/camino branch January 27, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require all paths to be UTF-8

3 participants