feat: implement API for providing custom index#241
Merged
vytautas-astrauskas-sensmetry merged 1 commit intomainfrom Mar 24, 2026
Merged
feat: implement API for providing custom index#241vytautas-astrauskas-sensmetry merged 1 commit intomainfrom
vytautas-astrauskas-sensmetry merged 1 commit intomainfrom
Conversation
vytautas-astrauskas-sensmetry
force-pushed
the
feat/custom-meta-index
branch
2 times, most recently
from
0e252d6 to
629c3d4
Compare
vytautas-astrauskas-sensmetry
requested review from
andrius-puksta-sensmetry,
consideRatio and
victor-linroth-sensmetry
core/src/project/local_src.rs
Outdated
Comment on lines
+236
to
+246
| pub fn update_index( | ||
| &mut self, | ||
| new_index: IndexMap<String, String>, | ||
| ) -> Result<(), LocalSrcError> { | ||
| let mut meta = self | ||
| .get_meta()? | ||
| .unwrap_or_else(InterchangeProjectMetadataRaw::default); | ||
| meta.index = new_index; | ||
| self.put_meta(&meta, true)?; | ||
| Ok(()) | ||
| } |
Collaborator
There was a problem hiding this comment.
Since this only uses .get_meta() and .put_meta() (and nothing specific to LocalSrcProject) it should go with the other utility functions in the ProjectMut trait.
Collaborator
Author
There was a problem hiding this comment.
Cannot do this anymore because 9314c8e added dependency on LocalSrcError.
Collaborator
There was a problem hiding this comment.
Why? ProjectMut returns project-specific errors, so every project type can return their own variant of this error.
IMO not worth doing it now, as there is no current usecase for other project types.
Collaborator
Author
There was a problem hiding this comment.
ProjectMut::Error is a type variable:
sysand/core/src/project/mod.rs
Lines 338 to 339 in 3661cd3
set_index method to ProjectMut, then it has to be abstract in the trait and have a concrete implementation for each project type. Alternatively, we could have an abstract method create_metadata_error that has a concrete implementation for each project type. In both cases, the effort does not feel worth it the gains at the moment.
bindings/java/java/src/main/java/com/sensmetry/sysand/Sysand.java
Outdated
Show resolved
Hide resolved
vytautas-astrauskas-sensmetry
force-pushed
the
feat/custom-meta-index
branch
from
e73d07b to
89fe21d
Compare
vytautas-astrauskas-sensmetry
requested review from
andrius-puksta-sensmetry and
victor-linroth-sensmetry
vytautas-astrauskas-sensmetry
force-pushed
the
feat/custom-meta-index
branch
2 times, most recently
from
18b6cde to
2a26f24
Compare
andrius-puksta-sensmetry
approved these changes
Mar 24, 2026
Collaborator
andrius-puksta-sensmetry
left a comment
andrius-puksta-sensmetry
left a comment
There was a problem hiding this comment.
Looks good.
vytautas-astrauskas-sensmetry
force-pushed
the
feat/custom-meta-index
branch
2 times, most recently
from
f902bc5 to
9cb2fe0
Compare
Signed-off-by: Vytautas Astrauskas <vytautas.astrauskas@sensmetry.com> Co-authored-by: Victor Linroth <victor.linroth@sensmetry.com> Co-authored-by: Andrius Pukšta <andrius.puksta@sensmetry.com> Signed-off-by: Vytautas Astrauskas <vytautas.astrauskas@sensmetry.com>
vytautas-astrauskas-sensmetry
force-pushed
the
feat/custom-meta-index
branch
from
9cb2fe0 to
0e1f870
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.