feat: add index management commands#335
Conversation
20e5dcc to
494e940
Compare
|
@andrius-puksta-sensmetry @consideRatio I'll add more tests and update documentation, but other parts are ready for review |
consideRatio
left a comment
There was a problem hiding this comment.
Nice @Jonas-Puksta-Sensmetry!!
I let codex make two PRs reflecting the two main non-blocking feedback points I had:
- I see index_utils.rs to contain shared data models between env/index.rs and commands/index/..., but think _utils doesn't reflect that, so I refactored it into index/{model|iri}.rs instead
PR to your PR with this change: Jonas-Puksta-Sensmetry#1 - I see commands/index/mod_tests.rs as integration tests, and as such they would belong into the core/tests folder.
PR to your PR with this change, and point 1, Jonas-Puksta-Sensmetry#2
|
Jonas highlighted these as action points:
@andrius-puksta-sensmetry could you consider merge of these? Then I figure we act on Jonas points ourselves. My input in #335 (review):
|
fd5c0f6 to
afc5aa2
Compare
afc5aa2 to
ec797fb
Compare
ec797fb to
9dfdc02
Compare
0057353 to
ea8cbef
Compare
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com> Co-authored-by: Erik Sundell <erik.sundell+2025@sensmetry.com>
Co-authored-by: Andrius Pukšta <andrius.puksta@sensmetry.com> Signed-off-by: Jonas Pukšta <146448971+Jonas-Puksta-Sensmetry@users.noreply.github.com>
…sion types Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
…pecifying publisher in .project.json Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
| you can add it to the package index by (provided .project.json specifies | ||
| `publisher` field): |
There was a problem hiding this comment.
| you can add it to the package index by (provided .project.json specifies | |
| `publisher` field): | |
| you can add it to the package index by (provided `.project.json` specifies | |
| matching `publisher` and `name` fields): |
Ideally there would be at least two examples:
- Project with appropriate (i.e. normalizable) publisher and name and no
--irigiven. - Project without publisher and with
--irigiven - (maybe) project with non-normalizable publisher/name and with
--irigiven - (maybe) project without a publisher and with
--irigiven
Alternatively/additionally, we should provide nice actionable error messages when publisher/name are not normalizable or publisher is missing, and direct people to give --iri when needed. Users will for sure find this whole situation of "optional publisher, and if publisher and name both satisfy specific rules, no --iri needs to be given; but if --iri PURL is given it must match publisher/name" confusing.
There was a problem hiding this comment.
Some of this should go to a new doc page explaining Sysand PURL and how exactly it corresponds to projects.
There was a problem hiding this comment.
None of this is urgent, but will have to be done soon-ish.
…is a positional argument for the other commands (yank and remove) Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
…, require `--project` flag for that Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
…on book Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
Co-authored-by: Andrius Pukšta <andrius.puksta@sensmetry.com> Signed-off-by: Jonas Pukšta <146448971+Jonas-Puksta-Sensmetry@users.noreply.github.com>
Signed-off-by: jonas.puksta.sensmetry <jonas.puksta@sensmetry.com>
andrius-puksta-sensmetry
left a comment
There was a problem hiding this comment.
Good enough, we'll definitely need to improve errors and docs, but that can wait a bit.
…ting to it in the corresponding repos
Uh oh!
There was an error while loading. Please reload this page.