Remove old include<i2s.h> on MozziGuts_impl_ESP8266.hpp to avoid build failure #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import of the lower case include will make compilation fail. The necessary include "I2S.h" (upper case) is already on line 43.
Collaborator
|
Hello, |
Owner
|
great! thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The include of "i2s.h" (lower case) will make compilation fail on esp8266.
The necessary include "I2S.h" (upper case) is already on line 43.
Removing the i2s.h (lower case) will build and work with i2s for both PDM and DAC cases.
For MOZZI_AUDIO_MODE = MOZZI_OUTPUT_PDM_VIA_I2S:
For MOZZI_AUDIO_MODE = MOZZI_OUTPUT_I2S_DAC: