Updates to check-megaraid-sas-status.rb#7
Closed
jdito wants to merge 7 commits intosensu-plugins:masterfrom
jdito:master
Closed
Updates to check-megaraid-sas-status.rb#7jdito wants to merge 7 commits intosensu-plugins:masterfrom jdito:master
jdito wants to merge 7 commits intosensu-plugins:masterfrom
jdito:master
Conversation
added 7 commits
August 17, 2016 14:29
Contributor
|
I think a better option would be to run the whole check under sudo. That would offer more flexibility on sudo options, the path to sudo itself, etc. Good catch on the typo, I fixed it in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
no
General
Purpose
Needed to be able to run with an unprivileged user in my environment. Flag defaults to false to prevent breaking existing configs. Please let me know if there's any other information needed.