Skip to content

Conversation

@thinkocapo
Copy link
Contributor

@thinkocapo thinkocapo commented Jan 20, 2022

Overview

Every new release we publish and run tests against will produce the same issues every time because they have the same fingerprints.

This PR introduces an update to the fingerprint using the release number(same technique as used in application-monitoring-javascript), so that when a new release is published, the fingerprint is unique to the release.

An SE tag can be set in .env so you can differentiate events from a React Native on your machine versus events from React Native in saucelabs.

Test - Fingerprint Update

Here's the issue Id (fingerprint) for the handled exception, before updating the fingerprinting algorithm.
image
WILL-REACT-NATIVE-6 issue link
image

Here's the issue Id (fingerprint) for the handled exception, after updating the fingerprinting algorithm to take the Release into consideration:
WILL-REACT-NATIVE-8 issue link
image
image

Lastly, this produced New Issues, which you can see in Release Health for the 2.0.7 release
image

Test - Environmental Variable SE

WILL-REACT-NATIVE-B
image

WILL-REACT-NATIVE-C
image

and you can see the difference here:
image

If you don't provide any .env file then the app still runs, and the SE variable will get ignored in source code.

@thinkocapo thinkocapo changed the title Fingerprint Update Fingerprint Update and Environmental Variable SE Jan 20, 2022
Copy link
Contributor

@cstavitsky cstavitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkocapo thinkocapo merged commit f5ac0e0 into sentry-demos:master Jan 24, 2022
@thinkocapo thinkocapo deleted the new-fingerprints branch January 24, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants