Various UX improvements#44
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR delivers several UX improvements to the SAMA monitoring application: active navigation highlighting in the top navbar, a live "blip" indicator on pages with auto-refresh, and a consistent loading spinner that stays visible during server-side redirects triggered by HTMX forms. It also extends the existing auto-refresh polling to the Checks/Details page and unifies the "Created" timestamp display across delete confirmation pages to use client-side locale formatting.
Changes:
- Active nav state: Adds an
IsActiveNavhelper to_Layout.cshtmlto highlight the correct navbar link based on the current URL, and removes the now-redundant "Home" nav link. - Live refresh indicator: Adds a CSS-animated "blip" dot to the header of pages with auto-refresh (Dashboard, Checks/Index, Checks/Details) that pulses on each polling cycle via HTMX OOB swaps.
- UX polish: Renames the "Dashboard" settings section to "Display", redirects after successful settings save, converts delete-form buttons to HTMX with a spinner, and uses locale-formatted
<time>elements on delete confirmation pages.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
SAMA.Web/wwwroot/js/site.js |
Adds htmx:afterRequest listener to keep the spinner class active during HX-Redirect navigations |
SAMA.Web/wwwroot/css/site.css |
Adds .live-indicator dot style and @keyframes live-blip animation |
SAMA.Web/Pages/Shared/_Layout.cshtml |
Adds IsActiveNav helper, applies active class to nav links, removes "Home" link |
SAMA.Web/Pages/Dashboard/Index.cshtml |
Adds live-indicator span to heading |
SAMA.Web/Pages/Checks/Index.cshtml |
Adds live-indicator span to heading |
SAMA.Web/Pages/Checks/Details.cshtml |
Adds polling placeholder, wraps live sections in OOB divs, adds live-indicator span |
SAMA.Web/Pages/Checks/Details.cshtml.cs |
Injects GlobalSettingsService to expose RefreshIntervalSeconds |
SAMA.Web/Pages/Alerts/Delete.cshtml |
Adds HTMX form with spinner, locale timestamps, updated warning copy |
SAMA.Web/Pages/Admin/Settings/Index.cshtml |
Renames section to "Display", updates icon to icon-monitor, updates help text |
SAMA.Web/Pages/Admin/Settings/Index.cshtml.cs |
Post handler now redirects instead of re-rendering; renames setting label |
SAMA.Web/Pages/Workspaces/Delete.cshtml |
Uses <time> element for locale "Created" date |
SAMA.Web/Pages/NotificationChannels/Delete.cshtml |
Uses <time> element for locale "Created" date |
SAMA.Web/Pages/Checks/Delete.cshtml |
Uses <time> element for locale "Created" date |
SAMA.Web/Pages/Admin/Users/Index.cshtml |
Switches table from table-striped to table-hover |
SAMA.Web/Pages/Admin/Users/Delete.cshtml |
Uses <time> element for locale "Created" date |
SAMA.Tests.Unit/Web/Pages/Checks/DetailsModelTests.cs |
Updates test setup to mock GlobalSettingsService |
SAMA.Tests.Unit/Web/Pages/Admin/Settings/IndexModelTests.cs |
Updates assertions from PageResult to RedirectToPageResult |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.