Show indexes query on Postgres fails to return functional indexes

[johnnncodes]

Model:

module.exports = function(sequelize, DataTypes) {
  var Model = sequelize.define('Company', {
    name: {
      type: DataTypes.STRING,
      unique: true
    }
  }, {
    indexes: [
      { name: 'unique_name', unique: true, fields: [sequelize.fn('lower', sequelize.col('name'))] }
    ]
  });

  return Model;
};

It works when the database is empty. But when I stop the server and then run it again. It throws this error:

Possibly unhandled SequelizeDatabaseError: relation "unique_name" already exists
    at module.exports.Query.formatError (/Users/johnkevinmbasco/webapps/helpdesk/node_modules/sequelize/lib/dialects/postgres/query.js:415:16)
    at null.<anonymous> (/Users/johnkevinmbasco/webapps/helpdesk/node_modules/sequelize/lib/dialects/postgres/query.js:110:21)
    at emit (events.js:95:17)
    at Query.handleError (/Users/johnkevinmbasco/webapps/helpdesk/node_modules/pg/lib/query.js:99:8)
    at null.<anonymous> (/Users/johnkevinmbasco/webapps/helpdesk/node_modules/pg/lib/client.js:166:26)
    at emit (events.js:95:17)
    at Socket.<anonymous> (/Users/johnkevinmbasco/webapps/helpdesk/node_modules/pg/lib/connection.js:109:12)
    at Socket.emit (events.js:95:17)
    at Socket.<anonymous> (_stream_readable.js:764:14)
    at Socket.emit (events.js:92:17)

The contents of my /bin/www file is similar to this - https://github.com/sequelize/express-example/blob/master/bin/www

[mickhansen]

It looks like it expects the table to be empty (like it would be with a force: true}) and not taking existing indexes into account, although i believe we had code for that @janmeier?

[janmeier]

Hmm, we should be checking if an index already exists before trying to create it. Which version are you on?

[johnnncodes]

@mickhansen @jamonkko Oh, I forgot to tell you guys that I'm passing {force: false} in the sync() method. Anyway, I'm using version 2.0.4

[johnnncodes]

Found a related issue - #2162 . It's already closed though.

[janmeier]

Whats the output of sequelize.QueryInterface.showIndex(Model.getTableName()). Seems like it does not find the existing index correctly.

Are you using schemas?

[johnnncodes]

@janmeier There's a typo, QueryInterface is undefined. queryInterface exists though. Here's the output:

{ _bitField: 0,
  _fulfillmentHandler0: undefined,
  _rejectionHandler0: undefined,
  _progressHandler0: undefined,
  _promise0: undefined,
  _receiver0: undefined,
  _settledValue: undefined,
  _boundTo: undefined,
  '$sql': [] }

What do you mean by "Are you using schemas?". If you're referring to Migrations / Manual schema changes, nope. No migrations yet.

[janmeier]

Sorry, I meant, whats the output by the actual query (.then(function (indices ..)

schema as in postgres schemas. But that's a no then ;)

[johnnncodes]

@janmeier

models.sequelize.queryInterface.showIndex(models.Company.getTableName()).then(function(result) {
  console.log(result);
});

Output:

[ { name: 'Companies_name_key',
    primary: false,
    unique: true,
    indkey: '2',
    definition: 'CREATE UNIQUE INDEX "Companies_name_key" ON "Companies" USING btree (name)',
    fields: [ [Object] ] },
  { name: 'Companies_pkey',
    primary: true,
    unique: true,
    indkey: '1',
    definition: 'CREATE UNIQUE INDEX "Companies_pkey" ON "Companies" USING btree (id)',
    fields: [ [Object] ] } ]

[mickhansen]

Hmm, unique_name is a bit generic, and index names for PG are global i believe - I believe we might only prefix auto generated names?

[janmeier]

We do indeed only prefix for auto generated. But since it works the first time I don't think there can be a collision..

[mickhansen]

Hmm, right

[janmeier]

Just tested locally, and it does indeed seem like the query fails to identify the index .. weird..

[janmeier]

Seems to be related to using functions in indices - without UPPER it works fine.