New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing connection mode to sqlite3 #4288

Closed
ysagal opened this Issue Aug 10, 2015 · 2 comments

Comments

2 participants
@ysagal
Contributor

ysagal commented Aug 10, 2015

sqlite3 supports passing of "mode" on new connections:

new sqlite3.Database(filename, [mode], [callback])
mode (optional): One or more of sqlite3.OPEN_READONLY, sqlite3.OPEN_READWRITE and sqlite3.OPEN_CREATE. The default value is OPEN_READWRITE | OPEN_CREATE.
https://github.com/mapbox/node-sqlite3/wiki/API

I believe this can be handled by passing mode to dialectOptions and modifying this line to pass it on to the sqlite3 library:
https://github.com/sequelize/sequelize/blob/master/lib/dialects/sqlite/connection-manager.js#L33

@janmeier

This comment has been minimized.

Member

janmeier commented Aug 11, 2015

Sure, PR welcome :-)

@ysagal

This comment has been minimized.

Contributor

ysagal commented Aug 11, 2015

Okie dokie #4302

@janmeier janmeier closed this Aug 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment