Scopes attributes are not merged

[lifenautjoe]

Version : 3.13.0
Dialect : mysql

Given

var User = sequelize.define('User', {
    username: {
        type: DataTypes.STRING,
        allowNull: false
    },
    about: {
        type: DataTypes.STRING
    },
    password: {
        type: DataTypes.STRING,
        allowNull: false,
        set: function (val) {
            // Some encrypting logic
        }
    }
}, {
    scopes: {
        'public': {
            attributes: [
                'id',
                'username',
                'about'
            ]
        },
        'private': {
            attributes: [
                'password'
            ]
        }
    }
});

When querying an instance with multiple scopes, scopes attributes do not get merged.
e.g.

User.scope('public','private').findOneById(1).then(function(user){
    console.log(user.about); // Exists, attribute included from public scope
    console.log(user.password); // Undefined, public and private attributes were not merged
});

[mickhansen]

@janmeier I consider this to be a bug, i don't believe we should merge into find.attributes but merging attributes from scopes seems like the right thing to do.

[janmeier]

Yep, agree :)

[sushantdhiman]

Hi @janmeier , @mickhansen , I was working on a fix and its easy to handle when attributes field is an Array. But look at this case of scope as Object

          lowAccessObj: {
             attributes: {
               include: ['other_value', 'access_level'],
               exclude: ['username']
             },
             where: {
               access_level: {
                 lte: 5
               }
             }
           },
           withNameObj: {
             attributes: {
               include: ['username'],
               exclude: ['access_level']
             },
           }

Now if we try to execute the query Model.scope('lowAccessObj','withNameObj').findOne() what should be the attributes included ?

At current code its easy to do application of one scope on other and thus using the resulting values something like this -

First apply scope : `lowAccessObj`
attributes : ['other_value', 'access_level']

Next apply scope : `withNameObj`
attributes : ['other_value', 'username']   // removed  'access_level'

[mickhansen]

@sushantdhiman Good question.

[thatisuday]

@mickhansen Is this included in v3.30.2 because it's not working out for me. #7302

[alxestevam]

Any updates? I'm having this problem too.

[math1974]

There are any updates on this issue? Still facing this problem

[ephys]

Please open a new issue with a description of your problem, this thread is extremely old and outdated