Added HasMany#injectCreator and Model.createAssociatedModel()#1213
Merged
mickhansen merged 7 commits intosequelize:masterfrom Jan 8, 2014
saschagehlich:feature/create-relation-objects
Merged
Added HasMany#injectCreator and Model.createAssociatedModel()#1213mickhansen merged 7 commits intosequelize:masterfrom saschagehlich:feature/create-relation-objects
mickhansen merged 7 commits intosequelize:masterfrom
saschagehlich:feature/create-relation-objects
Conversation
Contributor
Author
|
Also, renamed the HasManyMultiLinked variable to HasManyDoubleLinked |
Contributor
|
Good work, eventually we'll probably want to add createAssociatedModels and perhaps add it to belongsTo/hasOne aswell. But might aswell merge this now. |
lib/associations/has-many.js
Outdated
Contributor
There was a problem hiding this comment.
You need to pass on the transaction option here - Or transactions wont work with createAssociatonModel
Contributor
Author
There was a problem hiding this comment.
.addAssociation does not support transactions, so .createAssociation can't support them either (opened a ticket #1215, maybe I'll fix this today)
…re/create-relation-objects Conflicts: test/associations/has-many.test.js
…re/create-relation-objects
Contributor
|
Beautiful work. |
mickhansen
added a commit
that referenced
this pull request
Jan 8, 2014
…bjects Added HasMany#injectCreator and Model.createAssociatedModel()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.